Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery.hoverIntent.js is not updated #11656

Closed
sashberd opened this issue Aug 2, 2017 · 19 comments · Fixed by #11817
Closed

jquery.hoverIntent.js is not updated #11656

sashberd opened this issue Aug 2, 2017 · 19 comments · Fixed by #11817
Labels
🏷 Library Request A request to add a new library to cdnjs 🚨 High Priority

Comments

@sashberd
Copy link
Contributor

sashberd commented Aug 2, 2017

I just worked with this library and I think that the file in cdnjs is not latest or updated, nevertheless the versions in the files are the same
You can compare this file with one stored at cdnjs

FYR

@PeterDaveHello
Copy link
Contributor

Master branch will of course be different with the others, if there is any version update, then we should update it.

@sashberd
Copy link
Contributor Author

sashberd commented Aug 2, 2017

@PeterDaveHello So what usually we should do at such problem. Should I ask author to upgrade plugin?

@PeterDaveHello
Copy link
Contributor

@sashberd I haven't diggit yet, you can see if it's auto-update enabled on its page on CDNJS first.

@sashberd
Copy link
Contributor Author

sashberd commented Aug 2, 2017

@PeterDaveHello I think no, there is no auto-update
image

@PeterDaveHello
Copy link
Contributor

@sashberd so, of course, it needs manual updates.

@sashberd
Copy link
Contributor Author

sashberd commented Aug 2, 2017

@PeterDaveHello Would you like I will update package js to auto update?

@PeterDaveHello
Copy link
Contributor

@sashberd oops, I think are looking at a wrong page, that's not the page I mentioned. Looks like it has auto-update config.

@sashberd
Copy link
Contributor Author

sashberd commented Aug 2, 2017

@PeterDaveHello I am new here. I think you are talking about old process of auto update, are you? Where I should check it?

@PeterDaveHello
Copy link
Contributor

@sashberd I mean its page on cdnjs.com, where you find the library.

@PeterDaveHello
Copy link
Contributor

@sashberd As you can see here https://cdnjs.com/libraries/jquery.hoverintent, the lable shows "git autoupdate enabled", so the reason maybe 1) the author released a new version but forgot to add a git tag for its version, 2) the auto-update config is dated

@usmonster
Copy link
Contributor

Hello! This is because we indeed haven't tagged the version that's currently on master. You can see on the project's Milestones page that there are still a couple of small issues to close before we officially release version v1.9.0. This should be done within the next day or so—thanks for the poke!

In the meantime, feel free to close this issue, as it's not for the CDNJS folks to fix. ;)

@sashberd
Copy link
Contributor Author

sashberd commented Aug 3, 2017

@PeterDaveHello FYI

@sashberd sashberd closed this as completed Aug 3, 2017
@usmonster
Copy link
Contributor

FYI v1.9.0 is out, and I see it was auto-updated in CDNJS in a168be0 (🎉) , though there are still some small things that might need to be manually updated on the CDNJS side.

For example, it would be nice to synchronize the listed name and url (etc.) with what's in the official package.json. I also wonder if it's possible for CDNJS to use the official minified version, even though this comes without a sourcemap.

Thanks!

@sashberd sashberd reopened this Sep 4, 2017
@sashberd
Copy link
Contributor Author

sashberd commented Sep 4, 2017

@PeterDaveHello
Can we do improves by @usmonster asked?
Thanks

@sufuf3
Copy link
Contributor

sufuf3 commented Sep 4, 2017

@sashberd as a168be0#commitcomment-24072925 said, Would you help this issue?
the reason is https://github.com/cdnjs/cdnjs/blob/master/ajax/libs/jquery.hoverintent/package.json#L24 we just get the "jquery.hoverIntent.js" so we need to modify to "jquery.hoverIntent*" to get jquery.hoverIntent.min.js and jquery.hoverIntent.js.

So first commit, you could update the package.json and the commit message as the followings:

Update jquery.hoverintent auto-update config, close #11656

The second commit need to remove the jquery.hoverIntent.min.js.map and jquery.hoverIntent.min.js from CDNJS added, and add jquery.hoverIntent.min.js from https://github.com/briancherne/jquery-hoverIntent/blob/v1.9.0/jquery.hoverIntent.min.js

Thank you.

@sufuf3 sufuf3 added 🚨 High Priority 🏷 Library Request A request to add a new library to cdnjs labels Sep 4, 2017
@sashberd
Copy link
Contributor Author

sashberd commented Sep 6, 2017

@sufuf3
I made first commit
I did not understand what should be changed for second commit
Can you explain in details
Thanks

@sufuf3
Copy link
Contributor

sufuf3 commented Sep 6, 2017

Un.. actually you made three commits, and the first commit seems very OK.
let's remove 0dcbcb2 and 5de1b1b.
It's easy just type git reset --hard befcd1607d3020469a2c9e962c9c74a14e1b03d8.
After this command, we have to do as followings:

  1. delete jquery.hoverIntent.min.js.map and jquery.hoverIntent.min.js which under ajax/libs/jquery.hoverintent/1.9.0.
  2. download https://github.com/briancherne/jquery-hoverIntent/blob/v1.9.0/jquery.hoverIntent.min.js this file and add it under ajax/libs/jquery.hoverintent/1.9.0.

@sashberd
Copy link
Contributor Author

sashberd commented Sep 6, 2017

@sufuf3
Ok no problem
Today we have to continue conversation about my git problem, After this I will do above commits

@sufuf3
Copy link
Contributor

sufuf3 commented Sep 6, 2017

OK!
I just found you sent a PR #11785 on this issue.
But there are some git issues to solve.
We can deal with step by step.

sufuf3 pushed a commit to sashberd/cdnjs that referenced this issue Sep 14, 2017
Update auto-update config & homepage info of the lib. close cdnjs#11656
@ghost ghost removed the in progress label Sep 16, 2017
PeterDaveHello pushed a commit that referenced this issue Sep 16, 2017
Update auto-update config & homepage info of the lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷 Library Request A request to add a new library to cdnjs 🚨 High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants