Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swipeview.js 1.0 #1547

Closed
wants to merge 1 commit into from
Closed

Add swipeview.js 1.0 #1547

wants to merge 1 commit into from

Conversation

homerjam
Copy link

@Lockyc
Copy link
Contributor

Lockyc commented Jul 16, 2013

@homerjam Thanks for the pull request, we require the libraries to be git tagged so we can verify the files and provide reliable versioning for our users, can you please request a tag from the repo owner or submit an existing version and resubmit the pull request. Cheers

@Lockyc Lockyc closed this Jul 16, 2013
@homerjam
Copy link
Author

Forgive me, I did see that in the instructions but I'm not familiar with tagging and couldn't see where to do this.

From what I have read about tagging I understand that the commit should be tagged - is that correct? Should I just tag the commit in my fork of the repo? Do I need the repo owner, if so could you clarify what I need to ask them please?

Many thanks

@Lockyc
Copy link
Contributor

Lockyc commented Jul 17, 2013

@homerjam git tagging has to be done by the repo owner, it snapshots the code at a specific point in time, great for releases. We require the repo to be tagged so that we can provide reliable versioning for our users so there is a definite version 1.0 for the library etc. Just contact the repo owner and get them to tag the library at a version.

@homerjam
Copy link
Author

@Lockyc Thanks. I shall ask today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants