-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clmtrackr w/ git auto-update #308
Conversation
The auto-update glob is out-of-date, so let's switch to NPM and fix the glob. Refs #302
Hmm, the CI shouldn't fail if the file already exists. |
Agreed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
The switch to NPM was done on purpose, as checking for newer versions
should be faster (a few (one?) http call vs git clone). Don't we want that? :)
…On 5. juli 2020 16.06.25 "Matt (IPv4) Cowley" ***@***.***> wrote:
@MattIPv4 requested changes on this pull request.
Thanks :)
In packages/c/clmtrackr.json:
> + "source": "npm",
+ "target": "clmtrackr",
⬇️ Suggested change
- "source": "npm",
- "target": "clmtrackr",
+ "source": "git",
+ "target": "git://github.com/auduno/clmtrackr.git",
The git repo has the versions tagged correctly, let's not complicate the
change by updating where we get the files from.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
We discussed this internally -- unless we need to switch to make the package work, we'd much prefer to stay with the original source that the author chose for auto-updating. We don't have insight into why they chose Git over NPM, but there may be a reason. It also reduces the changes in the diff & reduces the risk of switching to an incorrect package, which has happened in a couple of the other PRs. |
Fair enough :) Should we update the doc and state that NPM is preferred? BTW: Do you use a tool to generate the glob url? |
Co-authored-by: Matt (IPv4) Cowley <me@mattcowley.co.uk>
I don't think so, we're happy with either being used. Git cloning is a bit slower for sure, but that's not our biggest worry really. I'm happy for folks to add packages with either as a source.
I built https://www.digitalocean.com/community/tools/glob a while back for testing globs easily on cdnjs, and even added a feature to quickly pull in files from an NPM package to make the whole process that much faster. The CI generates glob URLs that go to that tool as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
The auto-update glob is out-of-date, so let's switch to NPM and fix the
glob.
Refs #302