Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circliful w/ git auto-update #317

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Update circliful w/ git auto-update #317

merged 2 commits into from
Jul 7, 2020

Conversation

klausenbusk
Copy link
Contributor

@klausenbusk klausenbusk commented Jul 4, 2020

The auto-update config is out-of-date, so let's switch to NPM.

Refs #302


This pr was created with: #302 (comment)

The auto-update config is out-of-date, so let's switch to NPM.

Refs #302
packages/c/circliful.json Outdated Show resolved Hide resolved
packages/c/circliful.json Outdated Show resolved Hide resolved
@klausenbusk klausenbusk requested a review from MattIPv4 July 5, 2020 20:48
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more things on this one I've just realised, sorry:

  1. filename can be updated to just be circliful.js
  2. The url in repository needs to be updated to the renamed repo: pguso/js-plugin-circliful
  3. The target in autoupdate needs to be updated to the renamed repo: pguso/js-plugin-circliful

Co-authored-by: Matt (IPv4) Cowley <me@mattcowley.co.uk>
@klausenbusk
Copy link
Contributor Author

Few more things on this one I've just realised, sorry:

Fixed..

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm -- ty

@MattIPv4 MattIPv4 changed the title Update circliful w/ npm auto-update Update circliful w/ git auto-update Jul 7, 2020
@MattIPv4 MattIPv4 merged commit 8bf86ab into cdnjs:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants