Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date-fns w/ npm auto-update #1843

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Update date-fns w/ npm auto-update #1843

merged 3 commits into from
Jul 17, 2024

Conversation

JSkimming
Copy link
Contributor

@JSkimming JSkimming commented Jul 5, 2024

Releases since 2.0.0-alpha0 have not picked up any files; see release 2.20.0.

After highlighting this with the author, @kossnocorp, in issue date-fns/date-fns#3791, he gave the green light to try to fix it.

I've changed the following:

  1. Autoupdate from npm.
  2. Pick up files beginning with cdn. in all folders.
  3. Ignore versions containing a hyphen, as this seems to indicate pre-releases.
  4. Don't optimize JS files, as minified versions come with the package

Note

I could not find documentation for the ignore format, so I based my pattern on examples I found elsewhere.

@MattIPv4 MattIPv4 changed the title Change date-fns to autoupdate from npm instead of git Update date-fns w/ npm auto-update Jul 17, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty

@MattIPv4 MattIPv4 merged commit 5eaf4fb into cdnjs:master Jul 17, 2024
1 check passed
@JSkimming JSkimming deleted the update-date-fns-to-use-npm branch July 17, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants