Add ManUp.js w/ git auto-update #273
Conversation
Resolves #272 Signed-off-by: Aravind V Nair <22199259+aravindvnair99@users.noreply.github.com>
|
@MattIPv4 CI says |
| "license": "Apache-2.0", | ||
| "autoupdate": { | ||
| "source": "git", | ||
| "target": "git://github.com/boyofgreen/ManUp.js.git", |
There was a problem hiding this comment.
This repository has no tags in it, so we cannot pull any versioned files. Releases need to be tagged before we can use this as an autoupdate source.
There was a problem hiding this comment.
Ahh, yes... Thanks for the info. Is autoupdate a compulsory attribute? Because then I could remove that as judging by what ManUp.js is for, I don't think there would be an update anytime soon as HTML meta tags don't change frequently? Else, I guess I have to contact the owner of the repository to add a tag or release.
Also, shouldn't it be saying no version found on git instead of no version found on npm?
There was a problem hiding this comment.
Yes, auto-update is a required attribute, otherwise, we would have no way to add versioned files to the library.
(I've tracked the CI wording error in #275)
There was a problem hiding this comment.
Oh, thanks! Let me try contacting the owner in that case. Will close this PR and the related issue if the owner doesn't respond.
There was a problem hiding this comment.
Sounds good to me, thank you :)
Co-authored-by: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-authored-by: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-authored-by: Matt (IPv4) Cowley <me@mattcowley.co.uk>
|
Hey @aravindvnair99, It looks like there hasn't been any progress here so far? |
@MattIPv4 Yes, I agree with you. If @boyofgreen or @radiovisual don't respond, I shall close the issue tracker and pull request by this weekend. |
Why was I tagged in this thread? Was it a mistake, or am I missing something? |
@radiovisual That's in reference to boyofgreen/ManUp.js#11. I'm sorry if I wasn't supposed to tag you. I assumed you and @boyofgreen are the authors of ManUp.js after seeing the contributors list |
No, I only ever sent in a single PR to fix the documentation. So I wouldn't be able to help with this problem. |
@radiovisual My apologies for tagging you. Sorry for the inconvenience caused by my assumption. Have a great day! :) |
|
As there has still been no progress, I am going to close this PR. Please open a new PR if/when auto-update is available for this library. |
Resolves #272