Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS using chat #14

Closed
jlbribeiro opened this issue Mar 21, 2022 · 3 comments
Closed

XSS using chat #14

jlbribeiro opened this issue Mar 21, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@jlbribeiro
Copy link

jlbribeiro commented Mar 21, 2022

One for the backlog :)

Describe the bug
It is possible to run JavaScript on all clients by using the chat option.

To Reproduce
Steps to reproduce the behavior:

  1. Send <script>alert('Hello World!')</script> as a chat message.
  2. All clients display "Hello World!" as a blocking pop-up. The sending player appears to have sent an empty message (in the chat log).

Expected behavior
The text message should appear (literally) in the chat log, instead of being interpreted by the browser as code.

@cdot
Copy link
Owner

cdot commented Mar 21, 2022

Cool! I'll be honest, XSS vulnerabilities haven't been top of my priority list; though that really ought to be fixed.

cdot added a commit that referenced this issue Mar 21, 2022
@cdot
Copy link
Owner

cdot commented Mar 21, 2022

31eed27 should close that.

@cdot cdot closed this as completed Mar 21, 2022
@jlbribeiro
Copy link
Author

@cdot I figured it was not top priority, hence why I was just adding it to the "backlog" (I really just tried it out of curiosity).

Thanks for the fix!

@cdot cdot added the bug Something isn't working label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants