Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Reference: module not defined #57

Closed
gwhizoftv opened this issue Sep 20, 2022 · 3 comments
Closed

Uncaught Reference: module not defined #57

gwhizoftv opened this issue Sep 20, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@gwhizoftv
Copy link

Describe the bug
After deploying the docker, getting this error
To Reproduce
Deploy the docker.
Run the docker.
Notice the error in the console:
cldrpluralruleparser.cjs.js:308 Uncaught ReferenceError: module is not defined
at cldrpluralruleparser.cjs.js:308:1
(anonymous) @ cldrpluralruleparser.cjs.js:308

Expected behavior
No errors from spinning up and connecting to the game.

Screenshots
No errors on the screen, only in the console.

Desktop (please complete the following information):

  • OS: Linuz Debian 11 for the server, Macos for the client
  • Browser Chrome latest up to date

Smartphone (please complete the following information):
N/A

Additional context
Hot the same problem when building from source. Had to cd into the nodw_modules/cld* folder and npm init again.

@cdot cdot added the bug Something isn't working label Sep 20, 2022
@cdot
Copy link
Owner

cdot commented Sep 20, 2022

Thank you for reminding me. There are incompatibilities between AMD and cldpluralruleparser that I don't yet understand; the only way I could get it to work in the browser was to use the CommonJS module, which of course expects module to be defined (which it isn't in the browser). Will have another look at it; in the interim, this can be regarded as a warning; it doesn't affect the functioning of Xanado.

cdot added a commit that referenced this issue Sep 20, 2022
…i18n and assign global to eliminate error on startup
@cdot
Copy link
Owner

cdot commented Sep 20, 2022

Cured (on Firefox, at least) by using the version from @wikimedia/jquery.i18n and assigning a pluralRuleParser global.

@cdot cdot closed this as completed Sep 20, 2022
@gwhizoftv
Copy link
Author

gwhizoftv commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants