Some issues running code-server within code-server #4519
Assignees
Milestone
Comments
|
I think this is an edge case that can be moved to 4.0.1. @code-asher let me know if you disagree. |
|
This happens consistently and all you have to do is run code-server so
it does not feel like an edge case to me.
Anyone trying to develop code-server from code-server will run into
issues (for example from the product).
The extension installation hang is also consistent and pretty serious
IMO.
|
Didn't consider that scenario. Fair point! Moved back to 4.0.0 |
|
Heads-up: we've started working on this. |
code-asher
added a commit
to coder/vscode
that referenced
this issue
Dec 7, 2021
This partially fixes coder/code-server#4519. We use an environment variable to distinguish the parent process from the child so without sanitizing when you spawn code-server from VS Code it always looks like we are in the parent and the process will fail since it is not actually the child.
code-asher
added a commit
to code-asher/code-server
that referenced
this issue
Dec 7, 2021
This sanitizes our environment variables so code-server does not always think it is a child spawn. Fixes coder#4519.
code-asher
added a commit
that referenced
this issue
Dec 8, 2021
* Remove extra VS Code CLI spawn We already spawn VS Code's CLI when necessary in the lines below. Having the CLI spawn unconditionally when in a VS Code environment makes it impossible to run code-server within code-server (for example to develop it). * Update VS Code This sanitizes our environment variables so code-server does not always think it is a child spawn. Fixes #4519.
ZauberNerd
pushed a commit
to ZauberNerd/vscode
that referenced
this issue
Dec 23, 2021
This partially fixes coder/code-server#4519. We use an environment variable to distinguish the parent process from the child so without sanitizing when you spawn code-server from VS Code it always looks like we are in the parent and the process will fail since it is not actually the child.
ZauberNerd
pushed a commit
to ZauberNerd/vscode
that referenced
this issue
Dec 23, 2021
This partially fixes coder/code-server#4519. We use an environment variable to distinguish the parent process from the child so without sanitizing when you spawn code-server from VS Code it always looks like we are in the parent and the process will fail since it is not actually the child.
ZauberNerd
pushed a commit
to ZauberNerd/vscode
that referenced
this issue
Dec 23, 2021
This partially fixes coder/code-server#4519. We use an environment variable to distinguish the parent process from the child so without sanitizing when you spawn code-server from VS Code it always looks like we are in the parent and the process will fail since it is not actually the child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It should spin up a new code-server as long as something in the format
code-server [file]is not passed (in that case it opens in the existing instance) but it seems to spawn some other CLI instead.Installing extensions also seems to hang at the end.
The text was updated successfully, but these errors were encountered: