Fix typos in wget url #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jun 2, 2019
code-asher
approved these changes
Jun 3, 2019
|
@T45K could you please sign these commits so we can merge them in? |
|
@deansheather Sorry for my poor knowledge. I'm a novice at Git and GitHub and I didn't know I could sign my commit. Now, I have signed. Is this OK? |
|
Unfortunately not quite. You'll need to delete the last two commits from
your local repository, then amend the first commit you made with `git
commit --amend -S`.
…On Sun, 7 Jul. 2019, 5:16 pm t-nakagw, ***@***.***> wrote:
@deansheather <https://github.com/deansheather> Sorry for my poor
knowledge. I'm a novice at Git and GitHub and I didn't know I could sign my
commit. Now, I have signed. Is this OK?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#730>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACVYSVAWHUKIZK6BOTATK43P6GJ6VANCNFSM4HRGIZUQ>
.
|
|
@deansheather Thank you for your advice! |
|
Thanks! |
|
No. Thank YOU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
In url specified by
wget, there are unnecessary-s.Is there an open issue you can link to?
Unsure.