Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line dash option to Overlay class #147

Merged
merged 3 commits into from
May 21, 2024

Conversation

pmatsson
Copy link
Contributor

This Pull Request introduces a new feature to the Overlay class - the ability to draw shapes with dashed lines. This enhancement provides additional flexibility in the visual representation of shapes.

Please review the changes and provide any feedback. Thank you.

image

Copy link
Collaborator

@bmatthieu3 bmatthieu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution and simple to add too. Thank you. I have a few remarks:

  • Could you add a little documentation as well with the possible values of lineDash
  • I would also add a similar options for Catalog since they can have footprints associated.

@ManonMarchand
Copy link
Member

This feature would be nice for the support of regions visuals in cds-astro/ipyaladin#88
@bmatthieu3 is there something blocking the merge?

@bmatthieu3
Copy link
Collaborator

@ManonMarchand - Not that much, just some doc API that I will do

@bmatthieu3 bmatthieu3 merged commit bada1dc into cds-astro:develop May 21, 2024
2 checks passed
@bmatthieu3
Copy link
Collaborator

@pmatsson - Thanks, I fixed a little thing: when finishing drawing an overlay with a dash line, if there are other things to draw after, it would have drawn them dashed too.

@pmatsson pmatsson deleted the line-dash-option branch June 19, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants