Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to GitHub workflow to terraform apply #236

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

patheard
Copy link
Member

Summary

Switching to a GitHub terraform apply workflow to reduce the number of third
party tools that have access to our secrets..

@patheard patheard force-pushed the feat/github-terraform-apply branch from 8c7b17f to 06abe94 Compare April 19, 2022 17:39
@patheard patheard requested a review from mohdnr April 19, 2022 17:45
Copy link
Member

@CalvinRodo CalvinRodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮🐱

@github-actions
Copy link

DNS

✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 0 to change, 0 to destroy
Show plan
No changes. Infrastructure is up-to-date.

This means that Terraform did not detect any differences between your
configuration and real physical resources that exist. As a result, no
actions need to be performed.
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.alpha-canada-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.cds-snc-ca-public"]
WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.notification-canada-ca-public"]

19 tests, 16 passed, 3 warnings, 0 failures, 0 exceptions

Copy link
Contributor

@mohdnr mohdnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✅

@patheard patheard merged commit 9c7953b into master Apr 19, 2022
@patheard patheard deleted the feat/github-terraform-apply branch April 19, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants