Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: <gcds-topic-menu> doesn't look the between FR and EN #534

Closed
3 tasks done
gcharest opened this issue May 21, 2024 · 3 comments
Closed
3 tasks done

bug: <gcds-topic-menu> doesn't look the between FR and EN #534

gcharest opened this issue May 21, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@gcharest
Copy link

Prerequisites

GC Design System Components Package and Version

gcds-components@0.21.0

Current Behavior

The collapsed French button for the component is narrower and uses more vertical space than the English version.

image image

Expected Behavior

They should be the exact same width and height and the chevron should be on the same line.

System Info

The behaviour is observed on:
- Chrome 125.0.6422.61
- Firefox 126.0 (64-bit)
- Safari 17.5

Using macOS 14.5 on Intel MacBook Pro

Steps to Reproduce

  1. Visit the links to the components : https://design-system.alpha.canada.ca/en/components/theme-and-topic-menu/design/
  2. Scroll down to the menu button
  3. Toggle language switch
  4. Scroll down to the menu button

Code Reproduction URL

No response

Additional Information

No response

@daine daine added the bug Something isn't working label May 23, 2024
@adorayi adorayi added the help wanted Extra attention is needed label May 23, 2024
@melaniebmn
Copy link
Collaborator

Hi Guillaume, thank you for the bug report!

We fixed the issue in this PR, and it will go live with our next package release. Thank you so much for reporting this!

@gcharest
Copy link
Author

Thanks @melaniebmn ! I'll have a look at v0.22.0

I can also confirm that the issue wasn't present on v0.20.0 as I've been testing on various versions to see when the difference happened.

@melaniebmn
Copy link
Collaborator

Hey @gcharest, the bug was fixed yesterday with the version 0.22.1 release.
Here is the changelog for the change.

Closing the issue for now, but please let us know if it's still happening for you after upgrading to the newest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants