fix: misaligned of FR theme and topic menu button (bug) #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ethanWallace
added a commit
that referenced
this pull request
Jun 7, 2024
* chore(deps): update dependency prettier to v2.8.8 (#532) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: Add sleep to CDN publish of angular, react and vue packages (#530) * chore: GCDS Components Release v0.22.0 (#526) * chore: GCDS Components Release * chore: update lerna and changelog * Fix typo --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Ethan Wallace <ethan.wallace.91@gmail.com> * fix: Remove built in wrapper for React SSR react components * refactor: update input component to increase input width calculation (#536) refactor: update input component to increase input width calculation + remove max-length * chore(docs): Update and rename CONTRIBUTING.md to CONTRIBUTION GUIDELINES.md (#538) * Update and rename CONTRIBUTING.md to CONTRIBUTION GUIDELINES.md Updating contribution guidelines content in both English and French * Rename CONTRIBUTION GUIDELINES.md to CONTRIBUTING * Rename CONTRIBUTING to CONTRIBUTING.md * fix: misaligned of FR theme and topic menu button (bug) (#541) fix: misaligned of FR theme and topic menu button * docs: add fr translation for issue templates (contribution, feature request and bug report) (#533) * docs: add fr translation for issue templates (contribution) * chore: update translated template for bug reports * docs: update formatting * chore: add feature request issue template french translations * removing extra quotation mark Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com> * removing extra quotation mark Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com> --------- Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com> * chore(deps): update all non-major github action dependencies (#542) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency prettier to v2.8.8 (#543) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: change angular output install and build to be based off gcds-components package * chore: GCDS Components Release v0.22.1 (#537) * chore: GCDS Components Release * Update CHANGELOG.md * chore: update lerna version + changelog --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Melanie Boeckmann <melanie.bockmann@gmail.com> * chore: synced file(s) with cds-snc/site-reliability-engineering (#545) * chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml' * chore: synced local '.github/workflows/export_github_data.yml' with remote 'tools/sre_file_sync/export_github_data.yml' * chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml' --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> * chore(storybook): card property typos in Storybook (#544) fix: card property typos in Storybook * Update tsx version in react-ssr package * chore(storybook): add custom copy code button to storybook code preview (#540) * chore(storybook): add custom copy code button to storybook code preview * wip * damn you button haha * add min-width to copy button * revert button copy after 1.5 seconds * ci: easier way to run storybook from root (#547) * chore(deps): update dependency @angular/core to v10 [security] (#531) * chore(deps): update dependency @angular/core to v10 [security] * chore: Update angular dependencies --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ethan Wallace <ethan.wallace.91@gmail.com> * Change native props rendering * chore(storybook): Stop copy buttons rendering more than once (#550) chore(storybook): Stop copy buttons rendering more than once in storybook * Add React.HTMLAttributes<HTMLElement> to types * Update nx dependency * Fix hydration issues with boolean attributes --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com> Co-authored-by: Melanie Boeckmann <melanie.bockmann@gmail.com> Co-authored-by: Brock Higgins <47530176+brockhigg10@users.noreply.github.com> Co-authored-by: Daine Trinidad <daine.trinidad@cds-snc.ca> Co-authored-by: Élise Cossette <45772213+EliseKa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
The French theme and topic menu button was split into two lines because the host element of the screenreader-only component was set to
display: block;. Fixed it and it should display on one line now, like the EN menu button.Bug report