fix: Remove rxjs events to avoid duplicate custom events in Angular

[ethanWallace]

Summary | Résumé

With the v0.22.0 release of the @cdssnc/gcds-components-angular, @Outputs were added to the generated angular components. Unfortunately this was now causing custom events like gcdsClick to be emitted twice.

To fix, I removed Stencil's implementation of events from rxjs to remove the duplicate emitted events.

Example angular component

import {Component} from '@angular/core';

@Component({
  selector: 'app-click-me-gcds',
  template: ` <gcds-button type="button" (gcdsClick)="onClickMe()">Click me!</gcds-button>
    <gcds-pagination type="list" current-page="3" total-pages="20" (gcdsClick)="onClick($event)"></gcds-pagination>
`,
})
export class ClickMeGcdsComponent {
  clickMessage = '';

  onClickMe() {
    console.log('clicked')
  }
  onClick(event: any) {
    event.preventDefault();
    console.log(event.detail)
  }
}

Previously the gcdsClick would be emitted twice when either the button or pagination links were clicked. Now only one event is emitted.

[melaniebmn]

Thanks for adding extra comments :)

[melaniebmn]

LGTM

[daine]

FYI I'm still testing this -- should get to it by tonight :)

[daine]

Suggested change

	/**
	* Custom modification
	* - Replaced import { fromEvent } from 'rxjs'; with import { EventEmitter } from '@angular/core';
	*/
	/**
	* GCDS Modification
	* Replaced
	* import { fromEvent } from 'rxjs';
	* From: https://github.com/ionic-team/stencil-ds-output-targets/blob/9524c1ce970770e01afb493c292f71a2fe61b14a/packages/angular-output-target/angular-component-lib/utils.ts#L3
	*/

[daine]

Works pretty well, I tested by using our npm package 0.22.1 to verify that the events were being emitted twice, and then tested this PR and I can confirm that it is no longer firing twice.

Hoping to add more info in the comments about the changes so I added some suggestions in line. Thanks @ethanWallace !