Use the shortcode pool for Notify SMS #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sastels
requested review from
a team,
jimleroyer,
ben851 and
P0NDER0SA
and removed request for
a team
3 tasks
ben851
reviewed
Jul 10, 2024
| if template_id is not None and str(template_id) in self.current_app.config["AWS_PINPOINT_SC_TEMPLATE_IDS"]: | ||
| use_shortcode_pool = ( | ||
| str(template_id) in self.current_app.config["AWS_PINPOINT_SC_TEMPLATE_IDS"] | ||
| or str(service_id) == self.current_app.config["NOTIFY_SERVICE_ID"] |
There was a problem hiding this comment.
Why don't we just put the notify service id in the AWS_PINPOINT_SC_TEMPLATE_IDS?
There was a problem hiding this comment.
We could but we plan to move away from this env var entirely and have the pool choice be more dynamic. The NOTIFY_SERVICE_ID variable already exists so this way we don't need to change AWS_PINPOINT_SC_TEMPLATE_IDS and can eventually remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Use the shortcode pool for GC Notify's SMS.
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
Send SMS from the GC Notify service. Should be from the shortcode pool.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur