Pass custom http client through for the KeyStoreManager and jwks discovery #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotNorom
force-pushed
the
dev-custom-http-client-2
branch
from
6bd1ef7
to
57acc9d
Compare
NotNorom
force-pushed
the
dev-custom-http-client-2
branch
from
57acc9d
to
b01e7ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #42 I added the option for a custom http client. I missed a few areas leading to a situation where there are 2 differently configured http clients used right now.
This lead to a funny issue where the initial connection to a keycloak using a custom CA was working fine but all subsequent connection attempts failed because it used the default reqwest::Client instead...
I hope I found all spots this time.