Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjC: ctxt is a dictionnary with str keys #970

Closed
wants to merge 1 commit into from
Closed

ObjC: ctxt is a dictionnary with str keys #970

wants to merge 1 commit into from

Conversation

commial
Copy link
Contributor

@commial commial commented Feb 12, 2019

No description provided.

@commial commial mentioned this pull request Feb 12, 2019
Closed
2 tasks
@commial
ObjC: ctxt is a dictionnary with str keys
143201b 
Avoid distinction on size (ie, consider ExprId('a', 8) and ExprId('a', 16) have
the same type)
@commial
Copy link
Contributor Author

commial commented Feb 13, 2019

As discussed offline, this patch is wrong. We believe that:

  • Coming from C, we have to identify a type by its name, without any size expression
  • Coming from Expr, we want to be able to type any expression, from ExprId to complex ExprMem. So the size is relevant, and str identification is not

Additionally, C <-> Expr is not a bijection: there are ambiguity coming from Expr, especially for Union.

@commial commial closed this Feb 13, 2019
@commial commial deleted the fix/reduce_known_expr branch February 13, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@commial