[WIP] refactor: use C libcbor instead of msgpack cbor #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, some (if not all) issues we're seeing in this PR are related to PJK/libcbor-ruby#5. |
|
One concern I have here is that having to install It would be nice if we can package the library with the gem or provide pre-installed binaries like https://github.com/cowboyd/libv8 |
|
Yes, I agree it is not ideal to add a sys level dependency. It would be interesting to explore that possibility of packaging or providing binaries. If we do that, I'd consider first proposing that change to the libcbor gem. That's really were the dependency is coming from. |
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63
Blocked by PJK/libcbor-ruby#6Related cedarcode/cose-ruby#43