Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optimized vector format #22

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Use optimized vector format #22

merged 2 commits into from
Jun 27, 2023

Conversation

xvrh
Copy link
Contributor

@xvrh xvrh commented Jun 27, 2023

No description provided.

@cedvdb cedvdb merged commit e7eabaf into cedvdb:main Jun 27, 2023
@cedvdb
Copy link
Owner

cedvdb commented Jun 27, 2023

I'm reverting this as there didn't seem that there was any benefit (on the web) when images are preloaded.

If you require this or want to compare here is the compiled svg branch and here is the normal one

Both using a preloading mechanism. I did not find any difference (manual testing) so I'll merge the one that does not use precompiled picture.

@xvrh
Copy link
Contributor Author

xvrh commented Jun 27, 2023

I'm fine with a revert.

@cedvdb
Copy link
Owner

cedvdb commented Sep 25, 2023

Do you recall how were those images generated ? Looking at them right now I see those are square images while the original are circles.

@xvrh
Copy link
Contributor Author

xvrh commented Sep 25, 2023

@cedvdb The optimised .vec files are generated by running dart tool/compile_svgs.dart.

I see those are square images while the original are circles.

What do you mean exactly? I see the .svg are square. And they both (.svg & .vec) render as circle because of the ClipOval widget.

@cedvdb
Copy link
Owner

cedvdb commented Sep 25, 2023

Thanks ! tool wasn't part of main for some reason and it's been a long time.

What do you mean exactly?

The repository from which the svg are taken has circle flags. I was wondering if the fact that svgs are now squared flags is due to the optimization process that shows information that was hidden or if you changed those files yourself.

image

@cedvdb cedvdb mentioned this pull request Sep 25, 2023
@xvrh
Copy link
Contributor Author

xvrh commented Sep 25, 2023

tool wasn't part of main for some reason and it's been a long time.

This PR was reverted entirely with this commit: 15f3a57

The repository from which the svg are taken has circle flags

The flags seems to have turned square with this previous PR: #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants