Remove request.features
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 20, 2014 14:49
Decorating the `request` object causes issues if a Reflip-enabled Express app mounts a Reflip-enabled sub-app with different settings. For example, if app A configures Reflip with the `"aardvarks"` setting enabled, app B configures an independent instance of Reflip with `"aardvarks"` disabled, and A mounts B as a sub-app, `request.features.aardvarks` will be `false` if A mounts B after mounting the `flip` middleware, and `true` if A mounts `flip` after B. Instead of adding a separate `exportFeaturesName` option, `request.check()` now returns an object of feature names and their corresponding states if it is called without any arguments. This is a backward-incompatible change.
This allows features named `hasOwnProperty`. Isolate the `try...catch` statement around `JSON.parse()` in `FileAdapter#read()`.
`request.check()` now returns the internal cache instead of
constructing a new object. Mutating this object will affect the
results returned by `request.check('feature-name')`. This is
consistent with the v0.2.4 behavior.
| @@ -18,7 +18,7 @@ var Reflip = module.exports = function(opts) | |||
| assert(opts.storage || opts.features, 'You must pass either storage options or a pre-set feature object'); | |||
|
|
|||
| if (opts.features) this.features = opts.features; | |||
| if (opts.hasOwnProperty('default')) this.default = opts.default; | |||
| if (_.has(opts, 'default')) this.default = opts.default; | |||
There was a problem hiding this comment.
Your lodash fu is stronger than mine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorating the
requestobject causes issues if a Reflip-enabled Express app mounts a Reflip-enabled sub-app with different settings. If app A configures Reflip with"aardvarks"enabled, app B configures an independent Reflip instance with"aardvarks"disabled, and A mounts B as a sub-app,request.features.aardvarkswill befalseif A mounts B afterreflip.flip(), andtrueif A mounts.flip()after B.The internal cache of feature lookups is now exposed by calling
request.check()without any arguments. Mutating this object will affect the results returned byrequest.check('feature-name'), consistent with the current behavior.This is a backward-incompatible change, though. What do you think, @ceejbot?