Add overloads for EvaluateScriptAsync to support methodName and args #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PrinceOfEgypt Thanks, will try to look at this sometime next week. In the mean time if you could fix up the minor type |
|
@amaitland done, typo has been corrected |
amaitland
pushed a commit
that referenced
this pull request
Jul 12, 2016
…1738) * Add overloads for EvaluateScriptAsync to support passing in methodName and args * Fixing typo (teh => the)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two overloads for EvaluateScriptAsync to provide the option to pass in methodName and args instead of the string representation of the Javascript. Two overloads were needed because EvaluateScriptAsync already used an optional parameter, so it wouldn't be possible to mix both optional parameters and params in the same signature without forcing the callers to always use named parameters.