BrowserSubprocess - Refactor to support .Net Core #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
✅ Build CefSharp 76.1.90-CI3273 completed (commit 9f6989007e by @amaitland) |
kpreisser
added a commit
to kpreisser/CefSharp
that referenced
this pull request
Sep 6, 2019
-Add a reference to CefSharp.BrowserSubprocess.Core when compiling for .NET Core (see cefsharp#2891). -Adjust the references for .NET Core to not specify <Private>False<Private>, as otherwise they wouldn't be specified in the generated .deps.json file and so the CoreCLR wouldn't load them. Contributes to cefsharp#2796
9 tasks
- Added BrowserSubprocessExecutable for use with .Net Core (no WCF) - Added WcfBrowserSubprocessExecutable for use with the existing CefSharp.BrowserSubprocess.exe which supports WCF (conditionally)
amaitland
force-pushed
the
refactor/browsersubprocess
branch
from
d58b192
to
2e70c01
Compare
|
✅ Build CefSharp 76.1.90-CI3310 completed (commit 33e2a9e05a by @amaitland) |
|
✅ Build CefSharp 76.1.90-CI3311 completed (commit 01737aaa62 by @amaitland) |
|
Going with the class naming that I have for now, if anyone has a better suggestion then please let me know. Names can be easily changed until the first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2796
Summary:
Refactor the BrowserSubProcess so the core of it's implementation in
CefSharp.BrowserSubprocess.Core.Changes:
BrowserSubprocessExecutablefor use with .Net Core (no WCF)WcfBrowserSubprocessExecutablefor use with the existing CefSharp.BrowserSubprocess.exe which supports WCF (conditionally)How Has This Been Tested?
Javascript Bindingtests pass (both async and sync)Evalor javascript happens correctlyTypes of changes
Checklist:
TODO
WcfBrowserSubprocessExecutableProgram.csthat describe the new structure changes.