Add ScintillationGenerator and related data structures #1086
Conversation
whokion
added
enhancement
There was a problem hiding this comment.
Looks good @whokion! I have a few higher-level questions/comments before I look at the details of the generator.
|
@sethrj, @amandalund, @stognini I do not have a computer node to work on today and will address the rest of review comments later. Sorry about being delayed. |
… ScintillationInput
…umber of photons of the input distribution
whokion
force-pushed
the
scintillation_generator
branch
from
614b5d3
to
6276717
Compare
|
Not sure whether I addressed all review comments (seems that some of earlier comments are disappeared), but please let me know if there are additional comments. Thanks! |
There was a problem hiding this comment.
Looks great @whokion! Just a few more small comments from me.
|
@sethrj Not sure what the 1 pending check is, but I guess that all review comments are more or less addressed and this MR may be good enough to be merged now. Thanks you all for your review comments and good suggestions! |
|
@sethrj All done. Thanks! |
sethrj
changed the title
|
Nice work! Cross referencing with #886 . |
Add an initial set of codes for generating scintillation photons and related data structures.
This MR adds an initial/minimal set of codes for generating scintillation photons and related data structure - following the earlier work by @amandalund for
CerenvkovGeneratoras closely as possible. Nevertheless, a significant refactoring may be foreseen to consolidate the common code-basis and accommodate future developments for high-levelCerenkov and Scintillation processes.: