Fix non-sticky CMake options #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
core
sethrj
added a commit
to sethrj/celeritas
that referenced
this pull request
Feb 5, 2024
sethrj
added a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an upstream project sets a local default value for any of the Celeritas options with a predetermined list (RNG, geometry, units, ...) it creates a cache entry with the user-selected value. Previously the default cache entry would be blank, so that the first configure respects the default value but subsequent configures (if the upstream uses a "set default" mechanism) would reset to blank. This fixes the issue by writing the current value as the default cache value.