Basic geometry tracking on device #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK it looks like vecgeom@1.1.7 fails on device. Master seems to work. Can y'all make sure there are no egregious errors in this branch, then we can merge and rebase @mrguilima's branch, where we can fix anything as needed? |
pcanal
approved these changes
Aug 30, 2020
|
Thanks @pcanal ! |
Newer versions of vecgeom provide modern cmake targets.
This will make debugging easier, because failures will show up immediately after the kernel launch rather than at the next kernel launch.
This is loosely based on the vecgeom-test repository work. The current implementation is suitable only for straight-line propagation (neutral particles). The CUDA test fails because GlobalLocator is not currently implemented on device.
This is needed because vecgeom::cuda::GlobalLocator is not implemented.
Closed
sethrj
added
external
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pcanal I've been trying to work around the lack of on-device initialization by trying to reproduce your anticipated use case for VecGeom, namely initializing states on the host and then copying them over to GPU. The initialization and copying-to-device seems to work, but something's going wrong: it appears that
nav_state.Top()is valid but its value forGetLogicalVolume()is NULL.I can't debug on the Emmet installation of cuda at present (cuda-gdb is explicitly linked against a shared library version of ncurses 5 which doesn't appear to be on our system, only 6) so this was kind of hard to track down, and I'm not sure where to go from here.
Could you please take a look at this branch ASAP? Once we get tracking fully working on the device then let's get @mrguilima 's work rebased on top of it and go from there.
(Prerequisite for #22)