Increase max policy range for CMake to 3.18 #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.18 introduced policy
CMP0104
on the initialization of the newCMAKE_CUDA_ARCHITECTURES
variable and subsequent use of code generation flags. Without this policy being set toNEW
, warnings are emitted at CMake generation time aboutCUDA_ARCHITECTURES
not being set for targets.Bump max CMake policy range to 3.18 to set a default for
CMAKE_CUDA_ARCHITECTURES
if not supplied by the user.This can still result in
nvlink
errors when linkingvecgeom_static
if that was compiled with architectures incompatible(?) with that for Celeritas. Not sure how to check that yet.