-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export / import Geant4 XS tables, volume, material, and element information #55
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okeydoke, first round of comments coming in. Good work and functionality overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, Stefano -- this is really coming together. I've got a few more comments on the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good, I think this'll be the final iteration!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work Stefano! I'm going to build this on one or two configurations just to make sure everything works as expected, and will then merge.
@stognini Hey, I'm seeing a few "warnings-as-errors" on emmet: basically that |
Geant-exporter app now exports material and volume information using the GeantMaterialTable class. RootImporter loads data from the ROOT file into memory. The ImportMaterialTable class maps volume ids with their respective material ids, as well as providing methods to retrieve ImportMaterial and ImportVolume data. The material id allows finding the XS table of said material stored in ImportPhysicsTable objects.
05ec7fb
to
42ff00e
Compare
Damn, ok. I can fix them if you prefer.
I could not fix a compiler problem that appeared with that flag, so I disabled it until I could fix it. I'll try to get that running correctly (and compile things on emmet for the time being) to avoid future missing warnings. |
No problem, already done (and I squashed a lot of the work-in-progress-y commits to a very few). I'd be curious if you can reproduce the compiler problem; that small warning was the only thing I saw on my build. |
Add functionality to geant-exporter app to export XS tables, material, element, and volume information into a root file.
Add capability for Celeritas to import data from the root file, as well as retrieve volume, material, element, and XS table information as needed.
The import tool will run once and the imported data will be moved into future host/device classes, similar to the current ParticleParams.