Klein-Nishina CPU performance application #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
sethrj
reviewed
Oct 21, 2020
sethrj
approved these changes
Oct 22, 2020
|
Thanks for the CPU port @tmdelellis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CPU version of the Klein Nishina application. The same driver will work for both applications.
CELERITAS_USE_CUDAmust still be enabled to use the app because it will do some spurious copies to the device during the cross section setup (this does not get factored into runtime comparisons).The same driver code works for both applications except of course that the
grid_paramsgets ignored. To see an example and runtime comparisons between the CPU and GPU code see https://github.com/celeritas-project/benchmarks/blob/master/klein-nishina/celeritas-results-cpu/analysis.ipynb.This app does a traditional loop-based (history) approach for the tracks. It does not implement the same event loop algorithm as in the GPU case. Generally, the history approach is more efficient on the CPU side than the event approach, so this gives a fairer optimal-to-optimal comparison of runtimes.