Infrastructure: improved GPU and MPI granularity #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move helper code to detail subdir and namespace - Move kernels themselves into anonymous namespace for better compiler checking - Add mock CURAND struct and functions - Remove manual `target_link_libraries` in favor of test harness keywords (more robust against harness name changes)
With this it should be safe to run docker in parallel.
sethrj
force-pushed
the
gpu-test-lock
branch
2 times, most recently
from
479062b
to
c83f6d6
Compare
amandalund
requested changes
Dec 9, 2020
|
OK @amandalund I think I addressed all the issues -- good catch on the MPI communicator! |
amandalund
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eventsbranch into this one (@amandalund)