Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: improved GPU and MPI granularity #84

Merged
merged 7 commits into from Dec 9, 2020
Merged

Infrastructure: improved GPU and MPI granularity #84

merged 7 commits into from Dec 9, 2020

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Dec 7, 2020

  • Move the restructuring commit from the events branch into this one (@amandalund)
  • Add runtime environment switch to disable GPU support and reduce compiler macros in no-CUDA builds
  • Add switch to optionally disable MPI for reduced testing time and improved compatibility
  • Add runtime environment switch to change default logging level, and print debug level in tests when running debug build

@sethrj sethrj added the core Software engineering infrastructure label Dec 7, 2020
@sethrj
Add "nocuda" code and rearrange implementation to fix CUDA-free build
134bc3c 
- Move helper code to detail subdir and namespace
- Move kernels themselves into anonymous namespace for better compiler
  checking
- Add mock CURAND struct and functions
- Remove manual `target_link_libraries` in favor of test harness
  keywords (more robust against harness name changes)
@sethrj
Support log verbosity overrides with CELER_LOG/CELER_LOG_LOCAL env
eb6385c
@sethrj
Add runtime ability to disable CUDA
7003c22
@sethrj
Add GPU resource lock and disable when needed.
1aa8c7a 
With this it should be safe to run docker in parallel.
@sethrj sethrj force-pushed the gpu-test-lock branch 2 times, most recently from 479062b to c83f6d6 Compare December 9, 2020 01:34
amandalund
amandalund requested changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @sethrj!

cmake/CeleritasAddTest.cmake Outdated Show resolved Hide resolved
app/demo-interactor/demo-interactor.cc Show resolved Hide resolved
cmake/CeleritasAddTest.cmake Outdated Show resolved Hide resolved
@sethrj
Copy link
Member Author

sethrj commented Dec 9, 2020

OK @amandalund I think I addressed all the issues -- good catch on the MPI communicator!

@sethrj sethrj merged commit 98f80a5 into celeritas-project:master Dec 9, 2020
@sethrj sethrj deleted the gpu-test-lock branch December 10, 2020 17:11
@sethrj sethrj added the enhancement New feature or request label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandalund amandalund amandalund approved these changes

Assignees
No one assigned
Labels
core Software engineering infrastructure enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sethrj @amandalund