Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call ping to set connection for avoiding error (take place of #7215) #7220

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

uuip
Copy link
Contributor

@uuip uuip commented Jan 12, 2022

fix an error which is introduced by pr7040.

Description

when subscribed_to is empty , call ping to set connection attr .
After this operation, drain_events exec self._pubsub.get_message is ok,
and redis parse_response no error .

when subscribed_to is empty , call ping to set connection attr for avoiding redis parse_response error
@lgtm-com
Copy link

lgtm-com bot commented Jan 12, 2022

This pull request fixes 1 alert when merging 217a956 into 9377e94 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #7220 (217a956) into master (0620eb2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7220   +/-   ##
=======================================
  Coverage   89.31%   89.32%           
=======================================
  Files         138      138           
  Lines       16769    16770    +1     
  Branches     2450     2450           
=======================================
+ Hits        14977    14979    +2     
+ Misses       1560     1559    -1     
  Partials      232      232           
Flag Coverage Δ
unittests 89.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/backends/redis.py 92.22% <100.00%> (+0.02%) ⬆️
celery/backends/asynchronous.py 69.26% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9377e94...217a956. Read the comment docs.

@auvipy auvipy added this to the 5.2.x milestone Jan 12, 2022
@auvipy
Copy link
Member

auvipy commented Jan 12, 2022

looks good to me

@auvipy auvipy merged commit bc13e2f into celery:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants