fix an error which is introduced by pr7040. #7215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix an error which is introduced by pr7040. Nothing to subscribe so should not assign to _pubsub , then drain_events just sleep. The error introduced by pr7040 : `RuntimeError: pubsub connection not set: did you forget to call subscribe() or psubscribe()?`
if nothing to subscribe, don't call redis conn
|
This pull request introduces 3 alerts when merging 8c2e5a3 into 0620eb2 - view on LGTM.com new alerts:
|
auvipy
requested changes
Jan 10, 2022
|
This pull request fixes 2 alerts when merging 71a2e4a into 9377e94 - view on LGTM.com fixed alerts:
|
|
There seem to be network issues. so i restarted the build. in the mean time, can you add some additional unit tests for the proposed change? |
|
This pull request fixes 1 alert when merging 10e504a into 9377e94 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nothing to subscribe so should not assign to _pubsub , then drain_events just sleep. The error introduced by pr7040 :
RuntimeError: pubsub connection not set: did you forget to call subscribe() or psubscribe()?discussion