chore(ci): fix lint job #1718
Merged
chore(ci): fix lint job #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I’ve run last checks, this is ready for review 👍 |
auvipy
reviewed
May 14, 2023
setup.cfg
Outdated
| @@ -48,7 +48,7 @@ files = | |||
|
|
|||
|
|
|||
| [pep257] | |||
| ignore = D102,D104,D203,D105,D213 | |||
| ignore = D102,D107,D104,D203,D105,D205,D212,D213,D401,D412,D406,D407,D411,D413,D417 | |||
There was a problem hiding this comment.
are the failures too much to fix?
There was a problem hiding this comment.
I have to dig it into these issues but it seems to be only formatting issues, I can have a look.
There was a problem hiding this comment.
I fixed most of the rules, the other ones require some doc rewrite that can maybe be handled later ?
stegayet
force-pushed
the
chore/fix-lint-job
branch
2 times, most recently
from
f66c0f8
to
adf743a
Compare
auvipy
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1699.
This PR:
pydocstyleto 6.3.0 to have Python 3.10 supportpydocstyleto skip failures for now (let me know if you want to fix them in this PR)mypyerror