Correct order of Redis zadd dict elements
#953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changed `zadd()` behaviour in redis-py 3 states: https://github.com/andymccurdy/redis-py#mset-msetnx-and-zadd > For ZADD, the dict is a mapping of element-names -> score. So the dictionary generated for `zadd()` should be flipped around to have the `delivery_tag` as the key and the score as value. This commit fixes that.
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
=======================================
Coverage 88.66% 88.66%
=======================================
Files 63 63
Lines 6512 6512
Branches 777 777
=======================================
Hits 5774 5774
Misses 656 656
Partials 82 82
Continue to review full report at Codecov.
|
|
Thanks! Sorry I was making the change slightly blind to both how |
|
Any chance to have a Pypi release of this? |
lnielsen
pushed a commit
to inveniosoftware/invenio-indexer
that referenced
this pull request
Dec 3, 2018
* Pins Redis library to <3.0.0 due to incompatibilities that has to be addressed in Kombu (celery/kombu#953). (closes #93)
thedrow
pushed a commit
that referenced
this pull request
Dec 6, 2018
The changed `zadd()` behaviour in redis-py 3 states: https://github.com/andymccurdy/redis-py#mset-msetnx-and-zadd > For ZADD, the dict is a mapping of element-names -> score. So the dictionary generated for `zadd()` should be flipped around to have the `delivery_tag` as the key and the score as value. This commit fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed
zadd()behaviour in redis-py 3 states:https://github.com/andymccurdy/redis-py#mset-msetnx-and-zadd
So the dictionary generated for
zadd()should be flipped around to have thedelivery_tagas the key and the score as value. This commit fixes that.