Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGB investigate the EndBlocker panics and document them #501

Closed
Tracked by #301
rach-id opened this issue Jun 24, 2022 · 0 comments · Fixed by #1052
Closed
Tracked by #301

QGB investigate the EndBlocker panics and document them #501

rach-id opened this issue Jun 24, 2022 · 0 comments · Fixed by #1052
Assignees
@rach-id

Comments

@rach-id
Copy link
Member

rach-id commented Jun 24, 2022

as per normal, we just have to document when this panic can occur. we can handle this either in this PR or in a different issue

same with line 75

Originally posted by @evan-forbes in #497 (comment)
@rach-id rach-id added the C: QGB label Jun 24, 2022
This was referenced Jun 24, 2022
Merged
Closed
@rach-id rach-id mentioned this issue Aug 22, 2022
Merged
@rach-id rach-id self-assigned this Nov 22, 2022
@rach-id rach-id mentioned this issue Nov 22, 2022
Merged
5 tasks
rach-id added a commit that referenced this issue Nov 25, 2022
@rach-id @rootulp
docs: add qgb module readme (#1052)
c92cc8d 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes #501
<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

Co-authored-by: Rootul P <rootulp@gmail.com>
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rach-id @rootulp
docs: add qgb module readme (#1052)
1da6b0a 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes celestiaorg/celestia-app#501
<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add qgb module readme rach-id/celestia-app
1 participant
@rach-id