feat: Cache and traverse nmt sub tree roots #549
Conversation
Codecov Report
@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 38.53% 37.74% -0.79%
==========================================
Files 19 26 +7
Lines 2543 2726 +183
==========================================
+ Hits 980 1029 +49
- Misses 1478 1609 +131
- Partials 85 88 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment was marked as resolved.
This comment was marked as resolved.
pkg/inclusion/sub_tree_root.go
Outdated
| return strc.walk([]byte(children[1]), path[1:]) | ||
| default: | ||
| // this is unreachable code, but the compiler doesn't recognize this somehow | ||
| panic("bool other than true or false, computers were a mistake, everything is a lie, math is fake.") |
There was a problem hiding this comment.
everything is a lie, math is fake.
😆
Perhaps this is why John likes Rust so much (specifically Exhaustive Matches)
pkg/inclusion/sub_tree_root.go
Outdated
| } | ||
|
|
||
| // Constructor fullfills the rsmt2d.TreeCreatorFn by keeping a pointer to the | ||
| // cache and embedding it as a nmt.NodeVisitor into a new wrapped nmt. I only |
There was a problem hiding this comment.
I think the next line(s) of this doc comment were accidentally removed
Co-authored-by: Rootul Patel <rootulp@gmail.com>
Co-authored-by: Rootul Patel <rootulp@gmail.com>
kinda but not quite. I would like to have a working well tested version as to avoid changing things, but this will very likely look very similar to the final product so its probably safe to look at and review if you see anything. I think I renamed the files on a different branch that's further along, but that's it |
|
will break this this branch up a bit now that we have a better idea of what works and is needed |
evan-forbes
force-pushed
the
evan/msg-inclusion-api
branch
from
530c3e3
to
c006232
Compare
|
marking this ready for review again. It is unchanged from the last review, other than I spun off #621 and moved everything else the non-interactive-defaults feature branch |
Co-authored-by: Rootul Patel <rootulp@gmail.com>
Co-authored-by: Rootul Patel <rootulp@gmail.com>
Co-authored-by: Rootul Patel <rootulp@gmail.com>
Co-authored-by: Rootul Patel <rootulp@gmail.com>
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
|
wow, I thought I was replying to things here, but apparently github will treat it as a review if you have pending comments and just continue to add them as pending comments!! |
Description
spinning this out into its own PR. I think its mostly finished, so we can begin the review process imo, but I'm keeping as a draft for the moment as it might need to change and I don't really want to merge anything to master until we have fully functional non-interactive defaults.
a big part of #381