Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGB better e2e context and channel usage #562

Merged
merged 4 commits into from
Jul 27, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 26, 2022

  • Better usage of context (no more gymnastics)
  • Usage of two channels to organize communication between multiple go routines

Closes #522

@rach-id rach-id added enhancement New feature or request C: QGB labels Jul 26, 2022
@rach-id rach-id requested a review from evan-forbes July 26, 2022 11:10
@rach-id rach-id self-assigned this Jul 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #562 (05afd4a) into qgb-integration (3b3176c) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@                Coverage Diff                 @@
##           qgb-integration    #562      +/-   ##
==================================================
- Coverage             9.63%   9.58%   -0.06%     
==================================================
  Files                   55      55              
  Lines                 9401    9456      +55     
==================================================
  Hits                   906     906              
- Misses                8416    8471      +55     
  Partials                79      79              
Impacted Files Coverage Δ
e2e/qgb/qgb_network.go 0.00% <0.00%> (ø)
e2e/qgb/test_commons.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

e2e/qgb/qgb_network.go Outdated Show resolved Hide resolved
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
@rach-id rach-id merged commit 4feef98 into celestiaorg:qgb-integration Jul 27, 2022
@rach-id rach-id deleted the qgb_e2e_notify branch July 27, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants