chore: move scripts from contrib to scripts/ #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
chore
rootulp
commented
Aug 17, 2022
| @@ -6,3 +6,4 @@ build | |||
| coverage.txt | |||
| tools-stamp | |||
| .vscode | |||
| profile.out | |||
There was a problem hiding this comment.
This is a temp file generated by test_cover.sh
| @@ -15,7 +15,7 @@ COPY . . | |||
|
|
|||
There was a problem hiding this comment.
contrib/ seems like the wrong location for a Dockerfile considering we have docker/ so I moved this too.
This file may be entirely removable. Defer to reviewers if that's the case.
Closed
rootulp
added a commit
that referenced
this pull request
Aug 1, 2023
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this pull request
Aug 1, 2024
Closes celestiaorg/celestia-app#2118 Dockerfile.test was moved from `contrib/` to `docker` in celestiaorg/celestia-app#625 but it doesn't appear used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #624
I moved scripts from
contrib/toscripts/and updated references to these scriptsTesting
make test-coverruns the script