Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalidate reserved namespace ids in ValidateBasic #643

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 20, 2022

@rootulp rootulp self-assigned this Aug 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #643 (99c0ca0) into main (24bbf82) will increase coverage by 8.67%.
The diff coverage is 75.20%.

@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   29.78%   38.45%   +8.67%     
==========================================
  Files          16       19       +3     
  Lines        2055     2538     +483     
==========================================
+ Hits          612      976     +364     
- Misses       1382     1476      +94     
- Partials       61       86      +25     
Impacted Files Coverage Δ
pkg/shares/shares.go 50.00% <50.00%> (ø)
pkg/shares/share_splitting.go 75.00% <75.00%> (ø)
pkg/shares/share_merging.go 77.11% <77.11%> (ø)
x/payment/types/payfordata.go 77.20% <100.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp marked this pull request as ready for review August 20, 2022 02:01
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again for fixing this so quickly 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsgPayForData.ValidateBasic doesn't invalidate reserved namespaces
3 participants