test: AllSquareSizes #679
test: AllSquareSizes #679
Conversation
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 36.40% 36.87% +0.47%
==========================================
Files 25 25
Lines 2637 2671 +34
==========================================
+ Hits 960 985 +25
- Misses 1594 1600 +6
- Partials 83 86 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| } | ||
|
|
||
| tests := []testCase{ | ||
| {0, []uint64{2, 4, 8, 16, 32, 64, 128}}, // should this function return an error for a message size of 0? |
There was a problem hiding this comment.
this is a really good point! I'm not sure. Technically, iirc, messages of length zero are invalid, but handling that error each time we use this function seems cumbersome. Perhaps we should just handle that in validate basic (if we're not already) and then assume that its fine here.
There was a problem hiding this comment.
I pulled the trigger on merge before seeing this but agreed seems cumbersome to handle errors from this function and would prefer a validate basic check on message length.
|
really great comments on the test btw |
Closes #677