Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use squareSize instead of k or origSquareSize #705

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 13, 2022

Closes #687

Note this doesn't address celestiaorg/celestia-core#853

@rootulp rootulp added the chore optional label for items that follow the `chore` conventional commit label Sep 13, 2022
@rootulp rootulp self-assigned this Sep 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #705 (32421a1) into main (e089c7e) will increase coverage by 0.01%.
The diff coverage is 91.11%.

@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   42.73%   42.75%   +0.01%     
==========================================
  Files          30       30              
  Lines        3037     3038       +1     
==========================================
+ Hits         1298     1299       +1     
  Misses       1642     1642              
  Partials       97       97              
Impacted Files Coverage Δ
pkg/inclusion/get_commit.go 0.00% <0.00%> (ø)
pkg/shares/non_interactive_defaults.go 94.82% <85.71%> (ø)
pkg/inclusion/paths.go 100.00% <100.00%> (ø)
pkg/prove/proof.go 83.82% <100.00%> (ø)
pkg/shares/share_merging.go 70.78% <100.00%> (ø)
x/payment/types/payfordata.go 78.78% <100.00%> (ø)
x/payment/types/square_sizes.go 100.00% <100.00%> (ø)
x/payment/types/wirepayfordata.go 66.35% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp marked this pull request as ready for review September 13, 2022 23:49
@rootulp rootulp enabled auto-merge (squash) September 13, 2022 23:49
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rootulp rootulp merged commit cbda4f6 into celestiaorg:main Sep 14, 2022
@rootulp rootulp deleted the rp/square-size branch September 14, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore optional label for items that follow the `chore` conventional commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a single name for each variable that references square size
3 participants