Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: rename message_name_space_id to message_namespace_id #775

Merged
merged 3 commits into from
Sep 24, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 23, 2022

Closes #773

@rootulp rootulp self-assigned this Sep 23, 2022
@rootulp rootulp marked this pull request as draft September 23, 2022 15:05
@rootulp rootulp changed the title chore!: rename message_name_space_id to message_namespace_id chore!: rename message_name_space_id to message_namespace_id Sep 23, 2022
@rootulp rootulp marked this pull request as ready for review September 23, 2022 15:36
@rootulp rootulp enabled auto-merge (squash) September 23, 2022 15:36
evan-forbes
evan-forbes previously approved these changes Sep 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #775 (d0d0228) into main (dca08d7) will not change coverage.
The diff coverage is 78.94%.

@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   23.28%   23.28%           
=======================================
  Files          71       71           
  Lines        8788     8788           
=======================================
  Hits         2046     2046           
  Misses       6570     6570           
  Partials      172      172           
Impacted Files Coverage Δ
x/payment/types/tx.pb.go 18.04% <63.63%> (ø)
app/estimate_square_size.go 82.66% <100.00%> (ø)
app/parse_txs.go 64.00% <100.00%> (ø)
x/payment/types/wirepayfordata.go 66.35% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp merged commit ab55fc4 into celestiaorg:main Sep 24, 2022
@evan-forbes evan-forbes mentioned this pull request Sep 24, 2022
@rootulp rootulp deleted the rp/message-namespace-id branch September 24, 2022 19:37
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a consistent name for message_namespace_id
3 participants