test: transaction splitting #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
testing
|
ref: part of (and an improvement of!) #630 I think |
evan-forbes
reviewed
Sep 29, 2022
| 0x0, // reserved byte | ||
| 0x1, // unit length of first transaction | ||
| 0xa, // data of first transaction | ||
| }, bytes.Repeat([]byte{0}, 244)...), // padding |
There was a problem hiding this comment.
[optional]
these will technically break when we increase share size, I think we could subtract from the constants here, but considering we are rarely doing that I'm 100% fine with leaving it.
having a test that breaks on purpose if the share size is changed might even be desirable.
There was a problem hiding this comment.
Agreed, this test will definitely break when we increase share size because the bytes of padding will be incorrect and the reserved byte will likely be two bytes instead of one.
I'm on-board with having these tests break when we introduce share breaking changes.
evan-forbes
approved these changes
Sep 29, 2022
rootulp
added a commit
to rootulp/celestia-app
that referenced
this pull request
Sep 29, 2022
Define unit tests for transaction splitting. These should be helpful when we tackle celestiaorg#802
rach-id
pushed a commit
to rach-id/celestia-app
that referenced
this pull request
Nov 16, 2022
Define unit tests for transaction splitting. These should be helpful when we tackle celestiaorg#802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define unit tests for transaction splitting. These should be helpful when we tackle #802