Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FitsInSquare for case with 0 messages #853

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 10, 2022

@rootulp rootulp added the bug Something isn't working label Oct 10, 2022
@rootulp rootulp self-assigned this Oct 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #853 (7c29ac6) into main (a3830e3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   25.59%   25.64%   +0.05%     
==========================================
  Files          75       75              
  Lines        9273     9272       -1     
==========================================
+ Hits         2373     2378       +5     
+ Misses       6677     6673       -4     
+ Partials      223      221       -2     
Impacted Files Coverage Δ
pkg/shares/non_interactive_defaults.go 100.00% <100.00%> (+5.17%) ⬆️
pkg/prove/proof.go 83.56% <0.00%> (-0.12%) ⬇️
pkg/da/data_availability_header.go 81.14% <0.00%> (+2.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this so quick

@rootulp rootulp merged commit 48cc944 into celestiaorg:main Oct 11, 2022
@rootulp rootulp deleted the rp/fix-fits-in-square branch October 11, 2022 00:28
rach-id pushed a commit to rach-id/celestia-app that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FitsInSquare is incorrect for edge case
3 participants