Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: TestSubscriber can hang / sometimes fails due to context deadline exceeded #173

Closed
Wondertan opened this issue Nov 8, 2021 · 2 comments · Fixed by #186 or #342
Closed

tests: TestSubscriber can hang / sometimes fails due to context deadline exceeded #173

Wondertan opened this issue Nov 8, 2021 · 2 comments · Fixed by #186 or #342
Assignees
@renaynay
Labels
bug Something isn't working

Comments

@Wondertan
Copy link
Member

Proof

image

Refs

Found in #171

Possible solution

There has to be a small 200 milliseconds timeout after the first Subscription on PubSub Topic. Basically, we need to ensure that peers notified each other about joining a topic before they are sending the msg. Otherwise, msg will never find a recipient.
@Wondertan Wondertan added the bug Something isn't working label Nov 8, 2021
This was referenced Nov 8, 2021
Merged
Merged
Merged
@Wondertan Wondertan reopened this Nov 10, 2021
@Wondertan
Copy link
Member Author

Wondertan commented Nov 10, 2021 •
edited
Loading

Unfortunately, hangs still may happen. libp2p/go-libp2p-pubsub#452 to rescue

@Wondertan Wondertan mentioned this issue Nov 13, 2021
Merged
3 tasks
@renaynay
Copy link
Member

renaynay commented Jan 4, 2022

Flakey failures still happening despite libp2p fix.

context deadline exceeded

@renaynay renaynay changed the title tests: TestSubscriber can hang tests: TestSubscriber can hang / sometimes fails due to context deadline exceeded Jan 4, 2022
@renaynay renaynay moved this to TODO in Celestia Node Jan 11, 2022
@atoulme atoulme mentioned this issue Jan 12, 2022
Merged
@renaynay renaynay moved this from TODO to In Review in Celestia Node Jan 14, 2022
@renaynay renaynay assigned Wondertan and renaynay and unassigned Wondertan Jan 21, 2022
Repository owner moved this from In Review to Done in Celestia Node Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renaynay renaynay

Labels
bug Something isn't working
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
2 participants
@Wondertan @renaynay