node: Adding WithCoreClient option #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
force-pushed
the
hlib/node-settings
branch
from
c464f85
to
8a6e5a7
Compare
Bidon15
force-pushed
the
with_core_client
branch
from
9653801
to
ae20389
Compare
Bidon15
force-pushed
the
with_core_client
branch
from
9593105
to
06b6828
Compare
renaynay
previously approved these changes
Jan 3, 2022
Wondertan
previously approved these changes
Jan 3, 2022
|
@Bidon15 pls resolve merge conflict 🙏🏻 |
Added 1 test TestWithMockedCoreClient for full node
Bidon15
force-pushed
the
with_core_client
branch
from
06b6828
to
328a0b7
Compare
renaynay
approved these changes
Jan 4, 2022
Wondertan
approved these changes
Jan 4, 2022
Bidon15
added a commit
to Bidon15/celestia-node
that referenced
this pull request
Jan 11, 2022
* node: WithCoreClient Option Added 1 test TestWithMockedCoreClient for full node * node: update test withCoreClient * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #292 and #301
Adding CoreClient option for node
Closes #302