node: Adding WithHost options to settings section #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
force-pushed
the
hlib/node-settings
branch
from
c464f85
to
8a6e5a7
Compare
Removing append from overrides func Edit node.go Adding 1 test for checking withHost functionality
Bidon15
force-pushed
the
with_host_option
branch
from
87bc573
to
b8c163e
Compare
Wondertan
reviewed
Dec 24, 2021
Wondertan
approved these changes
Dec 24, 2021
renaynay
approved these changes
Dec 26, 2021
|
@renaynay, They are not going to be triggered by CLI, but by TestSwamp. TestSwamp needs to overwrite those with custom testing values. |
We need these flags to initialise the node with a predefined network and coreclient created by test swamp |
Bidon15
added a commit
to Bidon15/celestia-node
that referenced
this pull request
Jan 11, 2022
* node: Adding WithHost options to settings section Removing append from overrides func Edit node.go Adding 1 test for checking withHost functionality * node: fix withHost test case * update changelog * remove redundant code in newNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #292
Removing append from overrides func
Edit node.go
Adding 1 test for checking withHost functionality
Closes #299