Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: liveness test fix #15

Merged
merged 1 commit into from
Jan 20, 2021
Merged

ci: liveness test fix #15

merged 1 commit into from
Jan 20, 2021

Conversation

tac0turtle
Copy link
Collaborator

@tac0turtle tac0turtle commented Jan 20, 2021

Update from upstream (after v0.40.0)

Description

  • fix builder script

closes: #14


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle tac0turtle marked this pull request as ready for review January 20, 2021 16:26
@@ -11,7 +11,7 @@ set -ue
# - DEBUG

# Source builder's functions library
. /usr/local/share/cosmos-sdk/buildlib.sh
. /usr/local/share/tendermint/buildlib.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (liveness test passes) 👍🏼 I'll merge after CI finished

@liamsi liamsi merged commit 970f74a into master Jan 20, 2021
@liamsi liamsi deleted the fix-rbuilder-script branch January 20, 2021 17:04
tzdybal pushed a commit that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liveness Test fails in Github Actions
2 participants