Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add head Endpoint and Make Code-Blocks Scrollable #136

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Add head Endpoint and Make Code-Blocks Scrollable #136

merged 2 commits into from
Jun 7, 2022

Conversation

YazzyYaz
Copy link
Contributor

@YazzyYaz YazzyYaz commented Jun 6, 2022

Closes #134
Closes #92

@YazzyYaz YazzyYaz added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 6, 2022
@YazzyYaz YazzyYaz self-assigned this Jun 6, 2022
adlerjohn
adlerjohn reviewed Jun 6, 2022
View reviewed changes
Copy link
Member

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me from formatting perspective, will defer to @renaynay for the content of the response

tzdybal
tzdybal reviewed Jun 6, 2022
View reviewed changes
Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

renaynay
renaynay requested changes Jun 7, 2022
View reviewed changes
docs/developers/node-api.md Outdated Show resolved Hide resolved
@YazzyYaz @renaynay
Update docs/developers/node-api.md
a58e94a 
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
@YazzyYaz
Copy link
Contributor Author

YazzyYaz commented Jun 7, 2022

@renaynay merged your commit suggestion

@YazzyYaz YazzyYaz merged commit 71656ec into main Jun 7, 2022
@YazzyYaz YazzyYaz deleted the yaz.node_head branch June 8, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzdybal tzdybal tzdybal left review comments

@adlerjohn adlerjohn adlerjohn left review comments

@renaynay renaynay renaynay approved these changes

@liamsi liamsi Awaiting requested review from liamsi

Assignees

@YazzyYaz YazzyYaz

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add /head to API docs Long outputs
4 participants
@YazzyYaz @tzdybal @adlerjohn @renaynay