feat: verifies the namespace order for each tree node #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 95.70% 95.73% +0.03%
==========================================
Files 5 5
Lines 559 563 +4
==========================================
+ Hits 535 539 +4
Misses 14 14
Partials 10 10
|
staheri14
commented
May 3, 2023
| @@ -100,18 +100,6 @@ func Test_namespacedTreeHasher_HashNode(t *testing.T) { | |||
| concat([]byte{0, 0, 0, 0}, randHash), | |||
| concat([]byte{0, 0, 1, 1}, randHash))), | |||
| }, | |||
| // XXX: can this happen in practice? or is this an invalid state? | |||
There was a problem hiding this comment.
This test case has become invalid as a result of the changes made in this PR, since the minimum ID of the left child i.e., {1,1} is greater than its maximum NID i.e., {0,0}.
staheri14
commented
May 3, 2023
| } | ||
| } | ||
|
|
||
| func TestMin(t *testing.T) { |
There was a problem hiding this comment.
Added these test as the codcov was complaining about the lack of coverage for some part of the min function.
staheri14
commented
May 3, 2023
| @@ -735,3 +769,73 @@ func Test_MustHashLeaf_Panic(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestMax(t *testing.T) { | |||
There was a problem hiding this comment.
Added these tests for consistency with the tests developed for the min counterpart.
rootulp
approved these changes
May 3, 2023
evan-forbes
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #129.
Checklist